Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit

From: Andreas Gruenbacher

Date: Thu Mar 05 2026 - 13:14:13 EST


On Thu, Mar 5, 2026 at 5:34 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> > Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> > calls bio_io_error() which overwrites that value again. Fix that by
> > completing the bio separately after setting bio->bi_status.
>
> Looks good, but can you drop the pointless goto label renaming?
> I'd also be tempted to just open code the split error case instead
> of adding a label for it.

Feel free to adjust things as you see fit.

Andreas