Re: [PATCH v4 2/4] x86/cpu: Add platform ID to CPU info structure
From: Dave Hansen
Date: Thu Mar 05 2026 - 13:39:45 EST
On 3/4/26 18:26, Pawan Gupta wrote:
> Just want to make sure that c->intel_platform_id not getting explicitly
> initialized for !CONFIG_CPU_SUP_INTEL is okay. I believe it is fine because
> the global boot_cpu_data should be zero-initialized.
>
> I see model and stepping are being initialized in identify_cpu(), but I
> don't see any vendor specific initialization here:
>
> identify_cpu()
> {
> int i;
>
> c->loops_per_jiffy = loops_per_jiffy;
> c->x86_cache_size = 0;
> c->x86_vendor = X86_VENDOR_UNKNOWN;
> c->x86_model = c->x86_stepping = 0; /* So far unknown... */
Yeah, I believe it's OK. The model/stepping initialization is probably
unnecessary in the first place, and all of the Intel code that use the
platform IDs will have set it properly.