Re: [PATCH v10 07/10] gpu: nova-core: add PIO support for loading firmware images
From: Timur Tabi
Date: Thu Mar 05 2026 - 15:49:58 EST
On Sun, 2026-03-01 at 23:03 +0900, Alexandre Courbot wrote:
> ) -> Result {
> match self.hal.load_method() {
> LoadMethod::Dma => self.dma_load(dev, bar, fw),
> - LoadMethod::Pio => Err(ENOTSUPP),
> + LoadMethod::Pio => self.pio_load(bar, &fw.try_as_pio_loadable()?),
Wouldn't it be simpler to have pio_load() just extract the IMEM/DMEM values it needs from &fw,
instead of creating an adapter? The adapter just seems like overkill for something that's used only
once.