Re: [PATCH 08/11] vfio: Enable cdev noiommu mode under iommufd

[Jacob Pan]

Hi Jason,

On Fri, 27 Feb 2026 20:35:40 -0400
Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:

> On Sat, Feb 28, 2026 at 08:18:41AM +0800, kernel test robot wrote:
> > Kconfig warnings: (for reference only)
> >    WARNING: unmet direct dependencies detected for IOMMU_PT_AMDV1
> >    Depends on [n]: GENERIC_PT [=y] && IOMMU_PT [=y] &&
> > !GENERIC_ATOMIC64 [=y] Selected by [y]:
> >    - VFIO_NOIOMMU [=y] && VFIO [=y] && VFIO_GROUP [=y]  
> 
> Some kconfig stuff is missing, the iommufd IOMMU would only work with
> GENERIC_ATOMIC64
I don't quite understand this dependency on GENERIC_ATOMIC64, or you
mean the opposite? since we currently have:
config IOMMU_PT_AMDV1
	tristate "IOMMU page table for 64-bit AMD IOMMU v1"
	depends on !GENERIC_ATOMIC64 # for cmpxchg64

And I already have noiommu depends on AMDV1 for mock page tables.

Anyway, this particular build issue can be fixed by adding
IOMMU_SUPPORT. i.e.

diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig
index 1f3fd7140604..78feca3d0c8b 100644
--- a/drivers/vfio/Kconfig
+++ b/drivers/vfio/Kconfig
@@ -65,6 +65,7 @@ config VFIO_NOIOMMU
        select GENERIC_PT
        select IOMMU_PT
        select IOMMU_PT_AMDV1
+       depends on IOMMU_SUPPORT
        help