Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Ray Jui]

On Thu, Mar 5, 2026 at 3:47 PM Lee Yongjun <jun85566@xxxxxxxxx> wrote:

The Broadcom iProc SDHCI controller supports DMA, but its binding
schema does not allow the 'dma-coherent' property.

As a result, dtbs_check reports the following validation errors
on the Northstar2 SoC:

  mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
  are not allowed ('dma-coherent' was unexpected)
  mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
  are not allowed ('dma-coherent' was unexpected)

Allow the 'dma-coherent' property in the schema to fix the validation
errors and accurately reflect the hardware capability.

Signed-off-by: Lee Yongjun <jun85566@xxxxxxxxx>
---
 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
index 2f63f2cdeb71..579e44843404 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
@@ -38,6 +38,8 @@ properties:
     type: boolean
     description: Specifies that controller should use auto CMD12

+  dma-coherent: true
+

Yeah for Broadcom iProc SDHCI on ARM64 platforms (including NS2), cache coherent DMA is supported (as opposed to other 32-bit based ARM platforms).

Change looks good to me. Thanks!

 

 required:
   - compatible
   - reg
--
2.34.1

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature