Re: [PATCH v3 04/13] dt-bindings: power: supply: document Samsung S2M series PMIC charger device

[Rob Herring]

On Fri, Feb 27, 2026 at 07:56:58PM +0530, Kaustabh Chakraborty wrote:
> On 2026-02-25 11:44 +01:00, Krzysztof Kozlowski wrote:
> > On Wed, Feb 25, 2026 at 12:45:06AM +0530, Kaustabh Chakraborty wrote:
> >> +
> >> +  This is a part of device tree bindings for S2M and S5M family of Power
> >> +  Management IC (PMIC).
> >> +
> >> +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> >> +  additional information and example.
> >> +
> >> +allOf:
> >> +  - $ref: power-supply.yaml#
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - samsung,s2mu005-charger
> >
> > Review from v1 still applies. I think you ignored several reviews, so I
> > will mark entire patchset as changes requested.
> 
> Somehow I missed this one... anyways I address them here:
> 
>   Why do you need a dedicated child node for this? It's got one property,
>   other than the compatible, that you're using. It could easily just go
>   in the parent without a dedicated node etc.
> 
> The dt node also references a simple-battery node, that's why it's
> required.

That can go in the parent.

Rob