Re: [PATCH v10 05/10] gpu: nova-core: falcon: remove unwarranted safety check in dma_load

[Eliot Courtney]

On Sun Mar 1, 2026 at 11:03 PM JST, Alexandre Courbot wrote:
> This safety check was an assumption based on the firmwares we work with
> - it is not based on an actual hardware limitation. Thus, remove it.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/falcon.rs | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs
> index 450431804e1c..c02b73b1cfe6 100644
> --- a/drivers/gpu/nova-core/falcon.rs
> +++ b/drivers/gpu/nova-core/falcon.rs
> @@ -527,13 +527,6 @@ fn dma_load<F: FalconFirmware<Target = E> + FalconDmaLoadable>(
>          bar: &Bar0,
>          fw: &F,
>      ) -> Result {
> -        // The Non-Secure section only exists on firmware used by Turing and GA100, and
> -        // those platforms do not use DMA.
> -        if fw.imem_ns_load_params().is_some() {
> -            debug_assert!(false);
> -            return Err(EINVAL);
> -        }
> -
>          // Create DMA object with firmware content as the source of the DMA engine.
>          let dma_obj = DmaObject::from_data(dev, fw.as_slice())?;
>  

Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>