Re: [PATCH v6 3/3] scsi: bsg: add io_uring passthrough handler
From: Yang Xiuwei
Date: Thu Mar 05 2026 - 22:06:04 EST
On 2026-03-05 15:39, Bart Van Assche wrote:
> Why separate members for device_status, driver_status and host_status
> instead of storing the SCSI result (scsi_cmnd.result)?
You're right. Since scmd remains valid until blk_mq_free_request() is
called in the task work callback, we can extract all status information
directly from scmd->result in scsi_bsg_uring_task_cb() instead of storing
it in the PDU. This approach is cleaner and follows your suggestion to
read from scmd->result directly.
> Please remove the superfluous " & 0xff" from u8 expressions.
Done. Removed all unnecessary " & 0xff" from u8 expressions.
> Please use the status_byte() macro instead of open-coding it.
Done. Using status_byte() macro instead of open-coding
(scmd->result & 0xff).
Will include these changes in v7.
Best regards,
Yang Xiuwei