Re: [PATCH] greybus: es2: drop redundant device reference
From: kernel test robot
Date: Fri Mar 06 2026 - 00:31:06 EST
Hi Johan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v7.0-rc2 next-20260305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Johan-Hovold/greybus-es2-drop-redundant-device-reference/20260305-210146
base: linus/master
patch link: https://lore.kernel.org/r/20260305125036.10856-1-johan%40kernel.org
patch subject: [PATCH] greybus: es2: drop redundant device reference
config: i386-buildonly-randconfig-001-20260306 (https://download.01.org/0day-ci/archive/20260306/202603061306.GsnCxitD-lkp@xxxxxxxxx/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603061306.GsnCxitD-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603061306.GsnCxitD-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/greybus/es2.c: In function 'es2_destroy':
>> drivers/greybus/es2.c:775:28: warning: variable 'udev' set but not used [-Wunused-but-set-variable]
775 | struct usb_device *udev;
| ^~~~
vim +/udev +775 drivers/greybus/es2.c
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 772
57bc17ffc566de drivers/staging/greybus/es2.c Johan Hovold 2015-11-04 773 static void es2_destroy(struct es2_ap_dev *es2)
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 774 {
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 @775 struct usb_device *udev;
1521eb6b6995dd drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 776 struct urb *urb;
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 777 int i;
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 778
74cd6503e5d4f0 drivers/staging/greybus/es2.c Johan Hovold 2015-11-04 779 debugfs_remove(es2->apb_log_enable_dentry);
4b1d82047ebbb1 drivers/staging/greybus/es2.c Alex Elder 2015-10-27 780 usb_log_disable(es2);
ca3ec299c2d090 drivers/staging/greybus/es2.c Greg Kroah-Hartman 2015-03-27 781
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 782 /* Tear down everything! */
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 783 for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
1521eb6b6995dd drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 784 urb = es2->cport_out_urb[i];
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 785 usb_kill_urb(urb);
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 786 usb_free_urb(urb);
4b1d82047ebbb1 drivers/staging/greybus/es2.c Alex Elder 2015-10-27 787 es2->cport_out_urb[i] = NULL;
4b1d82047ebbb1 drivers/staging/greybus/es2.c Alex Elder 2015-10-27 788 es2->cport_out_urb_busy[i] = false; /* just to be anal */
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 789 }
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 790
9d9d3777a9db5c drivers/staging/greybus/es2.c Alexandre Bailon 2016-07-07 791 for (i = 0; i < NUM_ARPC_IN_URB; ++i) {
1521eb6b6995dd drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 792 usb_free_urb(es2->arpc_urb[i]);
9d9d3777a9db5c drivers/staging/greybus/es2.c Alexandre Bailon 2016-07-07 793 kfree(es2->arpc_buffer[i]);
9d9d3777a9db5c drivers/staging/greybus/es2.c Alexandre Bailon 2016-07-07 794 es2->arpc_buffer[i] = NULL;
9d9d3777a9db5c drivers/staging/greybus/es2.c Alexandre Bailon 2016-07-07 795 }
9d9d3777a9db5c drivers/staging/greybus/es2.c Alexandre Bailon 2016-07-07 796
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 797 for (i = 0; i < NUM_CPORT_IN_URB; ++i) {
7330c48ec09367 drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 798 usb_free_urb(es2->cport_in.urb[i]);
7330c48ec09367 drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 799 kfree(es2->cport_in.buffer[i]);
7330c48ec09367 drivers/staging/greybus/es2.c Greg Kroah-Hartman 2016-08-17 800 es2->cport_in.buffer[i] = NULL;
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 801 }
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 802
52033fdebc9202 drivers/staging/greybus/es2.c Vaibhav Agarwal 2016-05-27 803 /* release reserved CDSI0 and CDSI1 cports */
52033fdebc9202 drivers/staging/greybus/es2.c Vaibhav Agarwal 2016-05-27 804 gb_hd_cport_release_reserved(es2->hd, ES2_CPORT_CDSI1);
52033fdebc9202 drivers/staging/greybus/es2.c Vaibhav Agarwal 2016-05-27 805 gb_hd_cport_release_reserved(es2->hd, ES2_CPORT_CDSI0);
52033fdebc9202 drivers/staging/greybus/es2.c Vaibhav Agarwal 2016-05-27 806
4b1d82047ebbb1 drivers/staging/greybus/es2.c Alex Elder 2015-10-27 807 udev = es2->usb_dev;
c1700479845bc3 drivers/staging/greybus/es2.c Johan Hovold 2015-11-04 808 gb_hd_put(es2->hd);
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 809 }
f587027e793cf8 drivers/staging/greybus/gb-es2.c Greg Kroah-Hartman 2015-01-21 810
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki