Re: [PATCH v11 03/12] gpu: nova-core: falcon: rename load parameters to reflect DMA dependency
From: Eliot Courtney
Date: Fri Mar 06 2026 - 01:23:40 EST
On Fri Mar 6, 2026 at 1:52 PM JST, Alexandre Courbot wrote:
> The current `FalconLoadParams` and `FalconLoadTarget` types are fit for
> DMA loading, but not so much for PIO loading which will require its own
> types. Start by renaming them to something that indicates that they are
> indeed DMA-related.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
> --- a/drivers/gpu/nova-core/firmware.rs
> +++ b/drivers/gpu/nova-core/firmware.rs
> @@ -16,8 +16,8 @@
>
> use crate::{
> falcon::{
> + FalconDmaLoadTarget, //
> FalconFirmware,
> - FalconLoadTarget, //
nit: // guard on wrong line I think?, here and other places in this diff
Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>