Re: [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent

[Jiri Slaby]

On 06. 03. 26, 2:50, Jim Cromie wrote:
> Ratelimiting these pr_debug()s can reduce the console flood during
> bulk dynamic-debug activation, in environments where a serial console
> is used.
>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> ---
>   drivers/tty/serial/serial_core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 487756947a96..6db465619c70 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1790,8 +1790,8 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout)
>   
>   	expire = jiffies + timeout;
>   
> -	pr_debug("uart_wait_until_sent(%u), jiffies=%lu, expire=%lu...\n",
> -		port->line, jiffies, expire);
> +	pr_debug_ratelimited("waiting on (%u) jiffies=%lu, expire=%lu...\n",
> +			     port->line, jiffies, expire);

The changed message does not make any sense.


--
js
suse labs