Re: [PATCH v11 1/2] dt-bindings: hwmon: add support for MCP998X

From: Krzysztof Kozlowski

Date: Fri Mar 06 2026 - 02:34:05 EST


On Thu, Mar 05, 2026 at 05:26:04PM +0200, Victor Duicu wrote:
> Add devicetree schema for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
>
> Signed-off-by: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> ---

Why you are making it every time DIFFERENT changeset? Just look at your
change-ids. You made it impossible to compare your work!

b4 diff '20260305-add-mcp9982-hwmon-v11-0-6e914ba63239@xxxxxxxxxxxxx'
Grabbing thread from lore.kernel.org/all/20260305-add-mcp9982-hwmon-v11-0-6e914ba63239@xxxxxxxxxxxxx/t.mbox.gz
Checking for older revisions
---
Analyzing 4 messages in the thread
Could not find lower series to compare against.

This is completly broken way of using b4.


...

> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - microchip,mcp9982d
> + - microchip,mcp9983d
> + - microchip,mcp9984d
> + - microchip,mcp9985d
> + - microchip,mcp9933d
> + then:
> + properties:
> + interrupt-names:
> + items:
> + enum: [alert-therm, sys-shtdwn]

You need to list the items, so the first item is fixed.

Best regards,
Krzysztof