Re: [PATCH 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock

[Jian Hu]

On 3/5/2026 5:03 PM, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
>
> On jeu. 05 mars 2026 at 15:43, Jian Hu <jian.hu@xxxxxxxxxxx> wrote:
>
> > The mpll3 clock is a valid parent clock for sd_emmc and mipi_isp on
> > the Amlogic T7 SoC, but was missing from t7-peripherals-clkc.yaml.
> > Add it to enable proper clock parent configuration for these peripherals.
> ... but this changes the index of the clocks after this mpll3, and those
> index are supposed to be stable if I'm not mistaken.
>
> It is indeed more convenient to have the optional clocks at the end
> as it avoids writing multiple <0> in DT when we do not have them.
>
> At the very least, your commit description should say that this change
> will not break any existing DT because these bindings are not used yet.
>
> I leave it to the DT folks to say if the change is OK in such case.

You are right. I will add a commit description to explain this.

The clock controller node for amlogic,t7-peripherals-clkc has not been 
merged upstream yet.

This change modifies the clock index order, but it will not break any 
existing device tree

since the amlogic,t7-peripherals-clkc bindings are not used by any 
upstream or downstream DT yet.

I will send a v2 with an updated commit message.

> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/amlogic,t7-peripherals-clkc.yaml       | 8 ++++++--
> >   1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> > index 55bb73707d58..27cc1f331587 100644
> > --- a/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-peripherals-clkc.yaml
> > @@ -24,7 +24,7 @@ properties:
> >       const: 1
> >
> >     clocks:
> > -    minItems: 14
> > +    minItems: 15
> >       items:
> >         - description: input oscillator
> >         - description: input sys clk
> > @@ -40,12 +40,13 @@ properties:
> >         - description: input gp1 pll
> >         - description: input mpll1
> >         - description: input mpll2
> > +      - description: input mpll3
> >         - description: external input rmii oscillator (optional)
> >         - description: input video pll0 (optional)
> >         - description: external pad input for rtc (optional)
> >
> >     clock-names:
> > -    minItems: 14
> > +    minItems: 15
> >       items:
> >         - const: xtal
> >         - const: sys
> > @@ -61,6 +62,7 @@ properties:
> >         - const: gp1
> >         - const: mpll1
> >         - const: mpll2
> > +      - const: mpll3
> >         - const: ext_rmii
> >         - const: vid_pll0
> >         - const: ext_rtc
> > @@ -98,6 +100,7 @@ examples:
> >                        <&gp1 1>,
> >                        <&mpll 4>,
> >                        <&mpll 6>;
> > +                     <&mpll 8>;
> >               clock-names = "xtal",
> >                             "sys",
> >                             "fix",
> > @@ -112,5 +115,6 @@ examples:
> >                             "gp1",
> >                             "mpll1",
> >                             "mpll2";
> > +                          "mpll3";
> >           };
> >       };
> --
> Jerome