[PATCH v2 04/14] pinctrl: realtek: Simplify error handling with dev_err_probe()
From: Yu-Chun Lin
Date: Fri Mar 06 2026 - 02:56:23 EST
Convert the error handling code in probe() to use dev_err_probe() to
enhance semantic meaning.
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
---
Changes in v2:
- Add Bartosz's Reviewed-by tag.
drivers/pinctrl/realtek/pinctrl-rtd.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c
index 56fd3093c206..382bdae54bf3 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd.c
@@ -566,15 +566,14 @@ int rtd_pinctrl_probe(struct platform_device *pdev, const struct rtd_pinctrl_des
data->regmap_pinctrl = devm_regmap_init_mmio(data->dev, data->base,
&rtd_pinctrl_regmap_config);
- if (IS_ERR(data->regmap_pinctrl)) {
- dev_err(data->dev, "failed to init regmap: %ld\n",
- PTR_ERR(data->regmap_pinctrl));
- return PTR_ERR(data->regmap_pinctrl);
- }
+ if (IS_ERR(data->regmap_pinctrl))
+ return dev_err_probe(data->dev, PTR_ERR(data->regmap_pinctrl),
+ "Failed to init regmap\n");
data->pcdev = devm_pinctrl_register(&pdev->dev, &data->desc, data);
if (IS_ERR(data->pcdev))
- return PTR_ERR(data->pcdev);
+ return dev_err_probe(data->dev, PTR_ERR(data->pcdev),
+ "Failed to register pinctrl\n");
platform_set_drvdata(pdev, data);
--
2.34.1