Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Krzysztof Kozlowski]

On 06/03/2026 09:42, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 08:47:03AM +0900, Lee Yongjun wrote:
>> The Broadcom iProc SDHCI controller supports DMA, but its binding
>> schema does not allow the 'dma-coherent' property.
>>
>> As a result, dtbs_check reports the following validation errors
>> on the Northstar2 SoC:
>>
>>   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>>   are not allowed ('dma-coherent' was unexpected)
>>   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>>   are not allowed ('dma-coherent' was unexpected)
>>
>> Allow the 'dma-coherent' property in the schema to fix the validation
>> errors and accurately reflect the hardware capability.
> 
> So is the hardware capable of coherent DMA or not? Entire commit msg is
> silent about this and says how you fix warning without actually telling
> us that it is a correct fix.
> 

Heh, why am I reviewing it, it's obviously non-tested. Code is already
there!

NAK

Best regards,
Krzysztof