Re: [PATCH v10 00/21] wifi: nxpwifi: create nxpwifi to support

From: Johannes Berg

Date: Fri Mar 06 2026 - 04:22:24 EST


On Thu, 2026-03-05 at 22:39 +0800, Jeff Chen wrote:
> This series adds a new full-MAC Wi-Fi driver `nxpwifi` to support NXP
> IW611/IW612 chip family. These chips are tri-radio single-chip solutions
> with Wi-Fi 6(1x1, 2.4/5 GHz), Bluetooth 5.4, and IEEE 802.15.4.
> Communication with the external host is via SDIO interface. The driver is
> tested on i.MX8M Mini EVK in both STA and AP mode.

How exactly was it tested, it doesn't even build ;-)

There are a couple of things I'm not a huge fan of, in particular the
whole "IOCTL" layer which is reminiscent of wireless extensions (but
thankfully those aren't used here), and while I can't really review 35k
lines here, I don't think I have any real problem with this now.

As I also just said to Lachlan, I think you should probably send a pull
request with just a single patch adding the driver once reviews settle.

https://lore.kernel.org/linux-wireless/b71d0932b10b5c446681cef588cfcf6f869f3fca.camel@xxxxxxxxxxxxxxxx/

johannes