Re: [PATCH net-next v6 4/9] net: dsa: microchip: Add support for KSZ8463's PTP interrupts

[Bastien Curutchet]

Hi Vladimir

On 3/5/26 11:19 AM, Vladimir Oltean wrote:
> On Wed, Mar 04, 2026 at 11:18:55AM +0100, Bastien Curutchet (Schneider Electric) wrote:
> > +void ksz8463_ptp_irq_free(struct dsa_switch *ds)
> > +{
> > +	struct ksz_device *dev = ds->priv;
> > +	struct ksz_port *port1 = &dev->ports[0];
> > +	struct ksz_port *port2 = &dev->ports[1];
> > +	struct ksz_irq *ptpirq = &port1->ptpirq;
> > +
> > +	ksz8463_ptp_port_irq_teardown(port1);
> > +	ksz8463_ptp_port_irq_teardown(port2);
> > +	free_irq(ptpirq->irq_num, ptpirq);
> > +	irq_domain_remove(ptpirq->domain);
> > +}
>
> Teardown in the exact reverse order of ksz8463_ptp_irq_setup(), please
> (port1 vs port2). Place them next to each other so it's more obvious.

Ok, I'll do it in next iteration.


Best regards,
Bastien