Re: [PATCH v4 19/24] x86/virt/tdx: Update tdx_sysinfo and check features post-update
From: Huang, Kai
Date: Fri Mar 06 2026 - 04:36:25 EST
> >
> > I would just remove this comment since I don't see it says more than just
> > repeating the code below (which also has comments saying the same thing, in
> > a more elaborated way).
>
> I added the comment because the function name isn't immediately clear about
> what it does.
>
It says "post_update", so it is clear to me that it is for "all last steps"
need to be done in the kernel after module is updated.
> I'd like people to understand the function's purpose without
> reading the implementation (I also couldn't find a self-explanatory name for
> the function). So I'd prefer to revise the comment rather than remove it.
>
We can see exactly what is done as "post update" in the code.
And if you add more functionalities in the future to this function, you
don't have to modify the comment of the function to expand.
Anyway, up to you :-)