Re: [PATCH 1/5] pmdomain: mediatek: Fix power domain count

[AngeloGioacchino Del Regno]

Il 12/02/26 12:34, Ulf Hansson ha scritto:
> On Tue, 10 Feb 2026 at 06:40, Adam Ford <aford173@xxxxxxxxx> wrote:
> > The wrong value of the number of domains is wrong which leads to
> > failures when trying to enumerate nested power domains.
> >
> >   PM: genpd_xlate_onecell: invalid domain index 0
> >   PM: genpd_xlate_onecell: invalid domain index 1
> >   PM: genpd_xlate_onecell: invalid domain index 3
> >   PM: genpd_xlate_onecell: invalid domain index 4
> >   PM: genpd_xlate_onecell: invalid domain index 5
> >   PM: genpd_xlate_onecell: invalid domain index 13
> >   PM: genpd_xlate_onecell: invalid domain index 14
> >
> > Attempts to use these power domains fail, so fix this by
> > using the correct value of calculated power domains.
> >
> > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
>
> We should have a fixes tag for this too I think:
>
> Fixes: 88914db077b6 ("pmdomain: mediatek: Add support for Hardware
> Voter power domains")
>
>
> > ---
> >   drivers/pmdomain/mediatek/mtk-pm-domains.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pmdomain/mediatek/mtk-pm-domains.c b/drivers/pmdomain/mediatek/mtk-pm-domains.c
> > index 58648f4f689b..d2b8d0332951 100644
> > --- a/drivers/pmdomain/mediatek/mtk-pm-domains.c
> > +++ b/drivers/pmdomain/mediatek/mtk-pm-domains.c
> > @@ -1228,7 +1228,7 @@ static int scpsys_probe(struct platform_device *pdev)
> >          scpsys->soc_data = soc;
> >
> >          scpsys->pd_data.domains = scpsys->domains;
> > -       scpsys->pd_data.num_domains = soc->num_domains;
> > +       scpsys->pd_data.num_domains = num_domains;
>
> Not sure this is the complete fix, as scpsys_add_one_domain() seems to
> be using the wrong value of "num_domains" too, no?

No, scpsys_add_one_domain() uses num_domains from the soc_data for DIRECT_CTL,
which is expected. Maybe that can be improved, but it's how it is supposed to work.

So yeah, this patch is resolving an issue, and it is a complete fix.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> >          parent = dev->parent;
> >          if (!parent) {
> > --
> > 2.51.0
>
> Kind regards
> Uffe