Re: [PATCH v6 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
From: André Draszik
Date: Fri Mar 06 2026 - 05:10:25 EST
On Fri, 2026-03-06 at 08:36 +0100, Krzysztof Kozlowski wrote:
> On Thu, Mar 05, 2026 at 06:11:53AM +0000, André Draszik wrote:
> > The power domains are a property of / implemented in the PMU. As such,
> > they should be modelled as child nodes of the PMU.
> >
> > Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>
> It is impossible to test a binding in a meaning of "tests", thus you
> should not add Marek's tags to bindings patches.
Apologies, I think it was due to b4 applying to the series and this one
slipped by me. Will remove.
>
> > +patternProperties:
> > + "^power-domain@[0-9a-f]+$":
> > + type: object
> > + description: Child node describing one power domain within the PMU
> > +
> > + additionalProperties: true
> > +
> > + properties:
> > + compatible:
> > + const: google,gs101-pd
> > +
> > required:
> > - compatible
> > - reg
> > + - '#address-cells'
> > + - '#size-cells'
>
> I don't see improvements about quotes.
Odd, I'm sure I fixed them at some point. Let me respin this.
Thanks,
Andre'