Re: [PATCH v2 1/3] mm: khugepaged: export set_recommended_min_free_kbytes()

[Lorenzo Stoakes (Oracle)]

On Fri, Mar 06, 2026 at 11:20:57AM +0000, Lorenzo Stoakes (Oracle) wrote:
> >  include/linux/khugepaged.h | 1 +
> >  mm/khugepaged.c            | 2 +-
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/khugepaged.h b/include/linux/khugepaged.h
> > index d7a9053ff4fed..76252865fca4b 100644
> > --- a/include/linux/khugepaged.h
> > +++ b/include/linux/khugepaged.h
> > @@ -16,6 +16,7 @@ extern void __khugepaged_exit(struct mm_struct *mm);
> >  extern void khugepaged_enter_vma(struct vm_area_struct *vma,
> >  				 vm_flags_t vm_flags);
> >  extern void khugepaged_min_free_kbytes_update(void);
> > +extern void set_recommended_min_free_kbytes(void);
>
> Please drop the extern, it's a historic artifact that we clean up when we add
> new entries (I don't blame you for including it, it's a sort of 'unwritten'
> convention :P)

Oh, and with that fixed, feel free to add:

Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@xxxxxxxxxx>

To this patch on respin.

Cheers, Lorenzo