Re: [PATCH 1/2] perf cs-etm: Finish removal of ETM_OPT_*
From: James Clark
Date: Fri Mar 06 2026 - 08:06:50 EST
On 06/03/2026 12:27 pm, Leo Yan wrote:
On Fri, Mar 06, 2026 at 11:24:45AM +0000, Coresight ML wrote:
[...]
-static int cs_etm__setup_timeless_decoding(struct cs_etm_auxtrace *etm)
+static void cs_etm__setup_timeless_decoding(struct cs_etm_auxtrace *etm,
+ u64 *metadata)
nitpick: here it can avoid a new argument "metadata", directly retrieve
from etm->metadata[0]. Otherwise, LGTM.
Oh yeah, I thought it wasn't assigned yet but it is.