Re: [PATCH v2 08/11] scsi: ufs: ufs-qcom: Implement vops tx_eqtr_notify()

[Can Guo]

Hi Bean,

On 3/6/2026 5:17 AM, Bean Huo wrote:
> On Wed, 2026-03-04 at 05:53 -0800, Can Guo wrote:
> > freq)
> >          return min_t(u32, gear, hba->max_pwr_info.info.gear_rx);
> >   }
> >   
> > +static int ufs_qcom_change_power_mode(struct ufs_hba *hba,
> > +                                     struct ufs_pa_layer_attr *pwr_mode,
> > +                                     enum ufshcd_pmc_policy pmc_policy)
> > +{
> > +       int ret;
> > +
> > +       ret = ufs_qcom_pwr_change_notify(hba, PRE_CHANGE, pwr_mode);
> > +       if (ret) {
> > +               dev_err(hba->dev, "Power change notify (PRE_CHANGE) failed:
> > %d\n",
> > +                       ret);
> > +               return ret;
> > +       }
> > +
> > +       ret = ufshcd_change_power_mode(hba, pwr_mode, pmc_policy);
> > +       if (ret)
> > +               return ret;
> > +
> > +       ufs_qcom_pwr_change_notify(hba, POST_CHANGE, pwr_mode);
> > +
> > +       return ret;
> > +}
> seems Qcom UFS driver does duplicate notify now, above
> ufs_qcom_change_power_mode() does PRE/POST itself, then calls core
> ufshcd_change_power_mode() which already does PRE/POST, double side effects? or
> I am wrong?
You are right... I made a mistake when I cleaned up the code. Thanks for 
catching it.

Best Regards,
Can Guo.
> Kind regards,
> Bean