Re: [PATCH] media: chips-media: wave5: Fix possible ERR_PTR deference
From: Nicolas Dufresne
Date: Fri Mar 06 2026 - 09:00:24 EST
Hi,
Le vendredi 06 mars 2026 à 09:32 +0300, Alper Ak a écrit :
> Hello everyone, look like this patch hasn't been applied. Did I miss
> something I needed to do to get it applied? If there is anything I
> need to do, please let me know.
You received an Ack from the maintainer, and got a tested buy. But the patch has
been submitted while the merge window was closed, which is fine, but means there
is a small delay. It should be processed within the next two weeks. Your subject
suggest a theoretical bug, so it has not be been prioritized over other patches
in the queue.
regards,
Nicolas
>
> Markus Elfring <Markus.Elfring@xxxxxx>, 13 Şub 2026 Cum, 14:38
> tarihinde şunu yazdı:
> >
> > …
> > > or ERR_PTR() on failure. The return value was not checked and in the
> >
> > error pointer
> >
> > …
> > > Add proper IS_ERR() check after kthread_run(), log the error, set
> > > dev->irq_thread to NULL and fail the probe to prevent the driver
> > > from operating in a broken state.
> > …
> >
> > See also once more:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19#n34
> >
> >
> > Would a summary phrase like “Prevent error pointer dereference in
> > wave5_vpu_probe()”
> > be more appropriate?
> >
> > Regards,
> > Markus
Attachment:
signature.asc
Description: This is a digitally signed message part