Re: [PATCH 2/4] iio: frequency: admv4420: use dev_err_probe

[Andy Shevchenko]

On Fri, Mar 06, 2026 at 12:24:46PM +0200, Antoniu Miclaus wrote:
> Use dev_err_probe() instead of dev_err() in the probe path to ensure
> proper handling of deferred probing and to simplify error handling.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
After addressing the below.

...

>  	ret = admv4420_calc_parameters(st);
> -	if (ret) {
> -		dev_err(dev, "Failed calc parameters for %lld ", st->vco_freq_hz);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret,
> +				     "Failed calc parameters for %lld\n", st->vco_freq_hz);

Besides too long line, are you sure the lld is the proper specifier?
I.o.w. is it really signed long long? (It also adds missing '\n',
does it need to be mentioned in the commit message?)

-- 
With Best Regards,
Andy Shevchenko