Re: [PATCH v7 26/26] KVM: selftest: Add a selftest for VMRUN/#VMEXIT with unmappable vmcb12

[Yosry Ahmed]

> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> index b191c6cab57d..78a542c6ddf1 100644
> --- a/arch/x86/kvm/svm/nested.c
> +++ b/arch/x86/kvm/svm/nested.c
> @@ -1105,10 +1105,8 @@ int nested_svm_vmrun(struct kvm_vcpu *vcpu)
>
>         vmcb12_gpa = svm->vmcb->save.rax;
>         err = nested_svm_copy_vmcb12_to_cache(vcpu, vmcb12_gpa);
> -       if (err == -EFAULT) {
> -               kvm_inject_gp(vcpu, 0);
> -               return 1;
> -       }
> +       if (err == -EFAULT)
> +               return kvm_handle_memory_failure(vcpu, X86EMUL_UNHANDLEABLE, NULL);

Why not call kvm_prepare_emulation_failure_exit() directly? Is the
premise that kvm_handle_memory_failure() might evolve to do more
things for emulation failures that are specifically caused by memory
failures, other than potentially injecting an exception?