Re: [PATCH] perf test: Fix test case 120 and 121 for s390

[Ian Rogers]

On Fri, Mar 6, 2026 at 7:52 AM Jan Polensky <japo@xxxxxxxxxxxxx> wrote:
>
> On Fri, Mar 06, 2026 at 08:10:02AM +0100, Thomas Richter wrote:
> > Perf tests
> > 120: 'perf data convert --to-ctf' command test
> > 121: 'perf data convert --to-json' command test
> > fail on s390. It is caused by selecting the default event cycles
> > which does not exist on s390 z/VM. Use software event cpu-clock
> > and specify it explicitly on the command line.
> >
> > Output before:
> > ❯ perf test 120 121
> > 120: 'perf data convert --to-ctf' command test       : FAILED!
> > 121: 'perf data convert --to-json' command test      : FAILED!
> >
> > Output after:
> > ❯ perf test 120 121
> > 120: 'perf data convert --to-ctf' command test       : Ok
> > 121: 'perf data convert --to-json' command test      : Ok
> >
> > Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxx>
> [snip]
> Thanks for providing this, Thomas!
> Tested-by: Jan Polensky <japo@xxxxxxxxxxxxx>
> Reviewed-by: Jan Polensky <japo@xxxxxxxxxxxxx>

Should we not fallback for the cycles as a default event?
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/builtin-record.c#n1374
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/evsel.c#n3792

Thanks,
Ian