Re: [PATCH v2 04/15] dt-bindings: arm: fsl: change incorrect VAR-SOM-MX6UL references
From: Hugo Villeneuve
Date: Fri Mar 06 2026 - 12:00:10 EST
Hi Krzysztof,
On Fri, 6 Mar 2026 09:00:18 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On Thu, Mar 05, 2026 at 01:06:19PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> >
> > There is no Variscite module named VAR-SOM-MX6UL, but there is VAR-SOM-MX6
>
> And binding does not speak about VAR-SOM-MX6UL, so I find your commit
> msg extra confusing. It took me way too much time to decipher why you
> are doing this and this should be just simple correction of name to
> match the product expressed by compatible.
Yes you are absolutely right. The origin of the confusion is that at first
this patch was included with patch #3 of this serie:
Link: https://lore.kernel.org/all/20260305180651.1827087-4-hugo@xxxxxxxxxxx/ [1]
I split them to satisfy checkpatch for separate bindings patches, and copied the
commit message from [1].
I will simplify the commit title and message in the next version to:
---------------
dt-bindings: arm: fsl: fix SOM name description to match compatible
Fix SOM name description to VAR-SOM-6UL to match the product expressed by
compatible.
---------------
>
> BTW, the DTSI also has wrong name.
This was fixed in patch #3 [1] just before this one.
> > and also VAR-SOM-6UL, so it is confusing at first to know to which one it
> > refers to. The imx6ul-var-som* dts/dtsi supports only the VAR-SOM-6UL [1],
> > not VAR-SOM-MX6 [2], so modify comments and model descriptions accordingly.
> >
> > Link https://dev.variscite.com/var-som-6ul [1]
> > Link: https://dev.variscite.com/var-som-mx6 [2]
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof
>
--
Hugo Villeneuve