Re: [PATCH 1/8] mm: use zone lock guard in reserve_highatomic_pageblock()
From: Andrew Morton
Date: Fri Mar 06 2026 - 13:34:17 EST
On Fri, 6 Mar 2026 19:24:56 +0100 Vlastimil Babka <vbabka@xxxxxxxxxx> wrote:
> >>
> >> Is it worth it?
> >
> > This is being done all over the kernel. Perhaps we should look at ways to
> > make the generic infrastructure more performant?
>
> Yeah I don't think the guard construct in this case should be doing anything
> here that wouldn't allow the compiler to compile to the exactly same result
> as before? Either there's some problem with the infra, or we're just victim
> of compiler heuristics.
Sure, it'd be good to figure this out.
> In both cases imho worth looking into rather than
> rejecting the construct.
I'm not enjoying the ides of penalizing billions of machines all of the
time in order to make life a little easier for the developers. Seems
like a poor tradeoff.