Re: [PATCH v6 2/4] dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY

[Krzysztof Kozlowski]

On Fri, Mar 06, 2026 at 08:01:51PM +0100, Christian Marangi wrote:
> Add documentation for Airoha AN7581 USB PHY that describe the USB PHY
> for the USB controller.


A nit, subject: drop second/last, redundant "documentation for". The
"dt-bindings" prefix is already stating that these are docs.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Airoha AN7581 SoC support a maximum of 2 USB port. The USB 2.0 mode is
> always supported. The USB 3.0 mode is optional and depends on the Serdes
> mode currently configured on the system for the relevant USB port.
> 
> To correctly calibrate, the USB 2.0 port require correct value in
> "airoha,usb2-monitor-clk-sel" property. Both the 2 USB 2.0 port permit
> selecting one of the 4 monitor clock for calibration (internal clock not
> exposed to the system) but each port have only one of the 4 actually
> connected in HW hence the correct value needs to be specified in DT
> based on board and the physical port. Normally it's monitor clock 1 for
> USB1 and monitor clock 2 for USB2.

...

This must contain the header you are also adding/referencing here.


> diff --git a/MAINTAINERS b/MAINTAINERS
> index 364f0bec8748..d75f59118a9a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -779,6 +779,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml
>  F:	drivers/spi/spi-airoha-snfi.c
>  
> +AIROHA USB PHY DRIVER
> +M:	Christian Marangi <ansuelsmth@xxxxxxxxx>
> +L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml

No maintainers for the header?

> +
>  AIRSPY MEDIA DRIVER
>  L:	linux-media@xxxxxxxxxxxxxxx
>  S:	Orphan
> -- 
> 2.51.0
>