Re: [PATCH v2 09/14] dt-bindings: pinctrl: realtek: Rename 'realtek,duty-cycle' to 'realtek,pulse-width-adjust'
From: Krzysztof Kozlowski
Date: Sat Mar 07 2026 - 07:53:36 EST
On Fri, Mar 06, 2026 at 03:52:39PM +0800, Yu-Chun Lin wrote:
> From: Tzuyi Chang <tychang@xxxxxxxxxxx>
>
> Rename 'realtek,duty-cycle' to 'realtek,pulse-width-adjust'.
>
> The previous name was misleading because this hardware block is not a PWM
> generator. It does not generate a signal with a specific frequency and
> duty ratio.
>
> Instead, it provides a fixed nanosecond-level adjustment to the rising/
> falling edges of an existing signal.
>
> Signed-off-by: Tzuyi Chang <tychang@xxxxxxxxxxx>
> Co-developed-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> ---
> .../bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml | 9 ++++++---
> .../bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml | 9 ++++++---
> .../bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml | 9 ++++++---
> 3 files changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> index 90bd49d87d2e..7b3888b2cea8 100644
> --- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> @@ -133,10 +133,13 @@ patternProperties:
> minimum: 0
> maximum: 7
>
> - realtek,duty-cycle:
> + realtek,pulse-width-adjust:
No, that's ABI break without explanation. "misleading" is not the
sufficient argument for breaking ABI.
You are stuck with the ABI you added back in 2023.
Best regards,
Krzysztof