Re: [PATCH 2/2] staging: Add initial synology microp driver

[Markus Probst]

On Sat, 2026-03-07 at 08:15 +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 06, 2026 at 07:38:30PM +0000, Markus Probst wrote:
> > Add a initial synology microp driver, written in Rust, to the staging tree.
> > The driver targets a microcontroller found in Synology NAS devices. It
> > currently only supports controlling of the power led, status led, alert
> > led and usb led. Other components such as fan control or handling
> > on-device buttons will be added once the required rust abstractions are
> > there.
> > ---
> >  MAINTAINERS                                        |   6 +
> >  drivers/staging/Kconfig                            |   2 +
> >  drivers/staging/Makefile                           |   1 +
> >  drivers/staging/synology_microp/Kconfig            |   4 +
> >  drivers/staging/synology_microp/Makefile           |   2 +
> >  drivers/staging/synology_microp/TODO               |   8 +
> >  drivers/staging/synology_microp/command.rs         |  48 +++++
> >  drivers/staging/synology_microp/led.rs             | 229 +++++++++++++++++++++
> >  drivers/staging/synology_microp/synology_microp.rs |  73 +++++++
> >  rust/uapi/uapi_helper.h                            |   2 +
> >  10 files changed, 375 insertions(+)
> 
> No signed-off-by?
Signed-off-by: Markus Probst <markus.probst@xxxxxxxxx>

> 
> And why staging?  That's for stuff that needs obvious cleanups done to
> it, you don't list that here.
Because the driver is not done yet. There are components that do not
exist yet, because the rust abstractions are missing.

Merging an initial version of this driver into staging makes it
possible for the serdev and led rust abstractions to be merged (as
their now exists a driver). After this I can work on the missing rust
abstractions.

Once the driver is complete, is can be moved into the mfd tree.

> 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e9e83ab552c7..a1f8dec31db2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -25143,6 +25143,12 @@ L:	linux-fbdev@xxxxxxxxxxxxxxx
> >  S:	Maintained
> >  F:	drivers/staging/sm750fb/
> >  
> > +STAGING - SYNOLOGY MICROP DRIVER
> > +M:  Markus Probst <markus.probst@xxxxxxxxx>
> > +S:  Maintained
> > +F: Documentation/devicetree/bindings/mfd/synology,microp.yaml
> > +F: drivers/staging/synology_microp/
> 
> No tabs?
Will be fixed.

> 
> thanks,
> 
> greg k-h

Thanks
- Markus Probst

Attachment: signature.asc
Description: This is a digitally signed message part