Re: [PATCH 1/3] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
From: David Lechner
Date: Sat Mar 07 2026 - 11:56:09 EST
On 3/3/26 1:49 PM, Sirat wrote:
> Hi Conor,
>
> On Wed, Mar 4, 2026 at 1:12 AM Conor Dooley <conor@xxxxxxxxxx> wrote:
>>
>> On Tue, Mar 03, 2026 at 03:02:40PM +0600, Siratul Islam wrote:
>>> Add device tree binding documentation for the STMicroelectronics
>>> VL53L1X Time-of-Flight ranging sensor connected via I2C.
>>>
>>> Signed-off-by: Siratul Islam <email@xxxxxxxx>
>>> ---
>
>>> + vdd-supply: true
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>
>> Are you sure the supply is not mandatory?
>>
>
> It is mandatory. The driver uses non optional devm_regulator_get().
> Will make the binding
> match in v2.
>
> Thanks,
> Sirat
>From the point of view of the devicetree, it doesn't matter what
the driver does. It matters that the chip can't work without
power. ;-)