Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree

[Paul Adam]

On 26/03/05 10:47, Stephan Gerhold wrote:
> Did you mean "sleep" instead of "suspend" here? By default, there is
> "default", "init", "idle" and "sleep" [1], although drivers can request
> custom pinctrl states as well.
> 
> Note that even with "sleep", the pinctrl state will be rarely used on
> Linux. Drivers need to explicitly call pinctrl_pm_select_sleep_state()
> to trigger these, but only few drivers do that [2]. From a quick look,
> I suspect that only the &sdhc_2 sleep pinctrl here is currently used on
> Linux.
> 
> That doesn't mean that you can't add these pinctrl states (the DT is not
> supposed to be specific to one particular operating system), but it does
> mean that most of these are effectively untested right now. I would
> personally omit them.
> 
> [1]: https://elixir.bootlin.com/linux/v7.0-rc1/source/include/linux/pinctrl/pinctrl-state.h#L36
> [2]: https://elixir.bootlin.com/linux/v7.0-rc1/A/ident/pinctrl_pm_select_sleep_state

Thanks, I will remove them.

[...]

> Does this need to be always-on?

Still works without, will take it out.

Paul