Re: [PATCH v7 05/10] rust: io: add IoLoc and IoWrite types

From: Danilo Krummrich

Date: Sat Mar 07 2026 - 16:41:10 EST


On Sat Mar 7, 2026 at 10:10 PM CET, Gary Guo wrote:
>> But if we can agree on
>>
>> bar.put(Reg::foo());
>>
>> or even
>>
>> bar.write_val(Reg::foo());
>
> I'm okay with either.

write_val() or something similar please; put() is not a good choice for
something that does not release a reference count in the kernel.

(As for write_val(), I'm generally fine with the name, but I want to note that
it also may be slightly confusing as it is the two-argument write() method which
distinguishes between location and value, whereas this one combines the two.)