Re: [PATCH 2/2] staging: Add initial synology microp driver

[Greg Kroah-Hartman]

On Sat, Mar 07, 2026 at 12:58:31PM +0000, Markus Probst wrote:
> On Sat, 2026-03-07 at 08:15 +0100, Greg Kroah-Hartman wrote:
> > On Fri, Mar 06, 2026 at 07:38:30PM +0000, Markus Probst wrote:
> > > Add a initial synology microp driver, written in Rust, to the staging tree.
> > > The driver targets a microcontroller found in Synology NAS devices. It
> > > currently only supports controlling of the power led, status led, alert
> > > led and usb led. Other components such as fan control or handling
> > > on-device buttons will be added once the required rust abstractions are
> > > there.
> > > ---
> > >  MAINTAINERS                                        |   6 +
> > >  drivers/staging/Kconfig                            |   2 +
> > >  drivers/staging/Makefile                           |   1 +
> > >  drivers/staging/synology_microp/Kconfig            |   4 +
> > >  drivers/staging/synology_microp/Makefile           |   2 +
> > >  drivers/staging/synology_microp/TODO               |   8 +
> > >  drivers/staging/synology_microp/command.rs         |  48 +++++
> > >  drivers/staging/synology_microp/led.rs             | 229 +++++++++++++++++++++
> > >  drivers/staging/synology_microp/synology_microp.rs |  73 +++++++
> > >  rust/uapi/uapi_helper.h                            |   2 +
> > >  10 files changed, 375 insertions(+)
> > 
> > No signed-off-by?
> Signed-off-by: Markus Probst <markus.probst@xxxxxxxxx>

That has to go into the real part of the patch :)

> > 
> > And why staging?  That's for stuff that needs obvious cleanups done to
> > it, you don't list that here.
> Because the driver is not done yet. There are components that do not
> exist yet, because the rust abstractions are missing.

That is not what staging is for, sorry.  Please just work to get the
driver working properly and merge it to the correct location first.

thanks,

greg k-h