Re: [PATCH v2 1/3] x86/mce, EDAC/mce_amd: Reorder SMCA bank type enums

[Borislav Petkov]

On Sat, Mar 07, 2026 at 11:33:14AM -0500, Yazen Ghannam wrote:
> +/* Order by HWID then McaType with newline between HWID groups. */

So I would argue that keeping them *all* sorted the same makes reading and
touching that code the simplest. Because you will have to modify the same
spots when you add new ones and the hwid number doesn't really matter for
humans.

IOW, this:

/*
 * Format:
 * { bank_type, hwid_mcatype }
 *
 * alphanumerically sorted by bank type.
 */
static const struct smca_hwid smca_hwid_mcatypes[] = {
        { SMCA_CS,       HWID_MCATYPE(0x2E, 0x0)        },
        { SMCA_CS_V2,    HWID_MCATYPE(0x2E, 0x2)        },
        { SMCA_DE,       HWID_MCATYPE(0xB0, 0x3)        },
        { SMCA_EX,       HWID_MCATYPE(0xB0, 0x5)        },
        { SMCA_FP,       HWID_MCATYPE(0xB0, 0x6)        },
        { SMCA_GMI_PCS,  HWID_MCATYPE(0x241, 0x0)       },
        { SMCA_GMI_PHY,  HWID_MCATYPE(0x269, 0x0)       },
        { SMCA_IF,       HWID_MCATYPE(0xB0, 0x1)        },
        { SMCA_L2_CACHE, HWID_MCATYPE(0xB0, 0x2)        },
        { SMCA_L3_CACHE, HWID_MCATYPE(0xB0, 0x7)        },
        { SMCA_LS,       HWID_MCATYPE(0xB0, 0x0)        },
        { SMCA_LS_V2,    HWID_MCATYPE(0xB0, 0x10)       },
        { SMCA_MA_LLC,   HWID_MCATYPE(0x2E, 0x4)        },
        { SMCA_MP5,      HWID_MCATYPE(0x01, 0x2)        },
        { SMCA_MPDMA,    HWID_MCATYPE(0x01, 0x3)        },
        { SMCA_NBIF,     HWID_MCATYPE(0x6C, 0x0)        },
        { SMCA_NBIO,     HWID_MCATYPE(0x18, 0x0)        },
        { SMCA_PB,       HWID_MCATYPE(0x05, 0x0)        },
        { SMCA_PCIE,     HWID_MCATYPE(0x46, 0x0)        },
        { SMCA_PCIE_V2,  HWID_MCATYPE(0x46, 0x1)        },
        { SMCA_PIE,      HWID_MCATYPE(0x2E, 0x1)        },
        { SMCA_PSP,      HWID_MCATYPE(0xFF, 0x0)        },
        { SMCA_PSP_V2,   HWID_MCATYPE(0xFF, 0x1)        },
        { SMCA_RESERVED, HWID_MCATYPE(0x00, 0x0)        },
        { SMCA_SATA,     HWID_MCATYPE(0xA8, 0x0)        },
        { SMCA_SHUB,     HWID_MCATYPE(0x80, 0x0)        },
        { SMCA_SMU,      HWID_MCATYPE(0x01, 0x0)        },
        { SMCA_SMU_V2,   HWID_MCATYPE(0x01, 0x1)        },
        { SMCA_UMC,      HWID_MCATYPE(0x96, 0x0)        },
        { SMCA_UMC_V2,   HWID_MCATYPE(0x96, 0x1)        },
        { SMCA_USB,      HWID_MCATYPE(0xAA, 0x0)        },
        { SMCA_USR_CP,   HWID_MCATYPE(0x180, 0x0)       },
        { SMCA_USR_DP,   HWID_MCATYPE(0x170, 0x0)       },
        { SMCA_WAFL_PHY, HWID_MCATYPE(0x267, 0x0)       },
        { SMCA_XGMI_PCS, HWID_MCATYPE(0x50, 0x0)        },
        { SMCA_XGMI_PHY, HWID_MCATYPE(0x259, 0x0)       },
};

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette