Re: [PATCH v3 14/19] nvmem: microchip-otpc: Expose UID registers as 2nd nvmem device
From: Claudiu Beznea
Date: Sun Mar 08 2026 - 12:40:50 EST
Hi, Alexander,
On 2/20/26 12:38, Alexander Dahl wrote:
Hello Claudiu,
thanks for your feedback on this, see my remarks inline below.
Am Sat, Jan 31, 2026 at 06:11:56PM +0200 schrieb Claudiu Beznea:
On 1/20/26 17:44, Alexander Dahl wrote:
For SAM9X60 the Product UID x Register containing the Unique Product ID
is part of the OTPC registers.
SAMA7G5 as well.
We have everything at hand here to just
create a trivial nvmem device for those.
Please massage a bit the patch description to match https://www.kernel.org/doc/html/v6.13/process/submitting-patches.html#describe-your-changes
Signed-off-by: Alexander Dahl <ada@xxxxxxxxxxx>
---
Notes:
v3:
- no changes
v2:
- Use dev_err_probe() for error reporting (thanks Claudiu)
- Move required register definition over here from removed patch
drivers/nvmem/microchip-otpc.c | 38 +++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c
index 34c0d7611f3e4..b35ed13b004bb 100644
--- a/drivers/nvmem/microchip-otpc.c
+++ b/drivers/nvmem/microchip-otpc.c
@@ -25,10 +25,14 @@
#define MCHP_OTPC_HR (0x20)
#define MCHP_OTPC_HR_SIZE GENMASK(15, 8)
#define MCHP_OTPC_DR (0x24)
+#define MCHP_OTPC_UID0R (0x60)
#define MCHP_OTPC_NAME "mchp-otpc"
#define MCHP_OTPC_SIZE (11 * 1024)
+#define MCHP_OTPC_UID_NAME "mchp-uid"
+#define MCHP_OTPC_UID_SIZE 16
I think you can drop these as they are used (individually) in a single place.
If you don't mind I would rather keep it here together with already
present similar definitions, instead of sprinkling new literals over
this c file.
OK for me.
Thank you,
Claudiu