Re: [PATCH v3 2/3] dt-bindings: hwmon: pmbus/tps1689: Add TPS1689

From: Guenter Roeck

Date: Sun Mar 08 2026 - 13:31:44 EST


On Tue, Feb 17, 2026 at 10:12:02AM +0200, Stoyan Bogdanov wrote:
> Add device compatible support for TPS1689
>

The title and description of this patch are really misleading
since they don't mention that support is added to ti,tps25990.yaml.

Also, the "title" field in the .yaml file still refers to "Texas
Instruments TPS25990 Stackable eFuse" which isn't really accurate
anymore.

Guenter

> Signed-off-by: Stoyan Bogdanov <sbogdanov@xxxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml
> index f4115870e450..973ee00c2c49 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml
> @@ -16,7 +16,9 @@ description:
>
> properties:
> compatible:
> - const: ti,tps25990
> + enum:
> + - ti,tps1689
> + - ti,tps25990
>
> reg:
> maxItems: 1