Re: [PATCH v2] xfs: fix use-after-free of log items during AIL pushing

[Yuto Ohnuki]

> I think this should be broken up into separate commits. Certainly
> the unmount changes should be a standalone commit...

Hi Dave, thank you for the detailed review.

I've split the patch into 4 separate commits in v3 and addressed
your other feedback:

- Unmount reorder as a standalone patch
- Loop body factored into xfsaild_process_logitem() as a
  separate refactoring patch
- Passed ailp instead of dev to tracepoints
- Moved xfs_ail_push_class after xfs_log_item_class events
- Moved UAF-unsafe comments to after xfs_buf_relse()
- Added header comment on xfsaild_push_item() for lifetime rules

v3: https://lore.kernel.org/all/20260308182804.33127-6-ytohnuki@xxxxxxxxxx/

Please let me know if I've misunderstood any of your points.

Yuto



Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705