Re: [PATCH v2 2/2] mfd: Add initial synology microp driver

[Markus Probst]

On Sun, 2026-03-08 at 19:56 +0100, Greg Kroah-Hartman wrote:
> On Sun, Mar 08, 2026 at 06:41:20PM +0000, Markus Probst wrote:
> > +kernel::module_serdev_device_driver! {
> > +    type: SynologyMicropDriver,
> > +    name: "synology_microp",
> > +    authors: ["Markus Probst <markus.probst@xxxxxxxxx>"],
> > +    description: "Synology Microp driver",
> > +    license: "GPL v2",
> > +    params: {
> > +        check_fan: i32 {
> > +            default: 1,
> > +            description: "Check for cpu fan failures",
> > +        },
> > +    },
> 
> This is not the 1990's, please do not add new module parameters for no
> good reason.  This should be dynamic and per-device, not per-module.
agreed.

> why would you NOT want to check for cpu fan failures?

Because it is also triggered at low fan speeds, even if they are
intentionally set by the driver. While the parameter is 1, the driver
would enable those checks for fan failures and would prevent low fan
speeds. The parameter would allow it to disable this check and allow
for low fan speeds.

> 
> thanks,
> 
> greg k-h


Thanks
- Markus Probst

Attachment: signature.asc
Description: This is a digitally signed message part