Re: [PATCH] staging: media: atomisp: comprehensive coding style cleanup

[Andy Shevchenko]

On Sun, Mar 8, 2026 at 11:59 PM Laur <laurentiutopai2004@xxxxxxxxx> wrote:
>
> Clean up atomisp_cmd.c to comply with Linux Kernel coding standards.
> This patch addresses multiple checkpatch.pl issues:
> -Fixed block comment formatting(trailing */ on separate lines).
> -Replaced hardcoded function names in logs with %s and __func__.
> -Fixed comma spacing and converted leading spaces to tabs.
> -Removed redundant else branches and void return statements.
> -Merged multiple line dereferences to improve readability.

At least some of the pieces may be split to separate change(s).

...

> @@ -1024,11 +1022,9 @@ v4l2_fmt_to_sh_fmt(u32 fmt)
>                 return IA_CSS_FRAME_FORMAT_RGBA888;
>         case V4L2_PIX_FMT_RGB565:
>                 return IA_CSS_FRAME_FORMAT_RGB565;
> -#if 0
>         case V4L2_PIX_FMT_JPEG:
>         case V4L2_PIX_FMT_CUSTOM_M10MO_RAW:
>                 return IA_CSS_FRAME_FORMAT_BINARY_8;
> -#endif
>         case V4L2_PIX_FMT_SBGGR16:
>         case V4L2_PIX_FMT_SBGGR10:
>         case V4L2_PIX_FMT_SGBRG10:

You need to understand the code you are modifying. Blind follow of the
tool that has tons of false positives (checkpatch is a recommendation
tool, it doesn't mean it's sometimes correct or useful) is not good
idea.

NAK.

-- 
With Best Regards,
Andy Shevchenko