Re: 回复: [PATCH] arm64: dts: cix: Add scmi powerdomain nodes for sky1

[Krzysztof Kozlowski]

On 09/03/2026 02:56, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for your comments
> 
>> EXTERNAL EMAIL
>>
>> On 06/03/2026 10:06, Gary Yang wrote:
>>> Add a second SCMI channel using SMC transport to communicate with TF-A
>>> for power domain management on the Sky1 SoC.
>>>
>>> Signed-off-by: Gary Yang <gary.yang@xxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/cix/sky1-power.h | 34
>>> ++++++++++++++++++++++++++++
>>
>> Why do you add dead code?
>>
> 
> The power domain serves as the foundation for serval modules with independent power domains.

So you add dead code because power domains are foundation? No. Dead code
is still dead code.

> For example, you will see GPU patch based on this patch soon. SKY1_PD_GPU is used in its dts node.

There is no such patch.

> 
> If take any mistakes or miss any information, please let us know.

Don't ever add dead code.

> 



Best regards,
Krzysztof