Re: [PATCH v2 1/2] dt-bindings: mfd: Add synology,microp device

[Krzysztof Kozlowski]

On 08/03/2026 19:41, Markus Probst wrote:
> Add the Synology Microp devicetree bindings. Those devices are
> microcontrollers found on Synology NAS devices. They are connected to a
> serial port on the host device.
> 
> Those devices are used to control certain LEDs, fan speeds, a beeper, to
> handle buttons, fan failures and to properly shutdown and reboot the
> device.
> 
> Signed-off-by: Markus Probst <markus.probst@xxxxxxxxx>
> ---
>  .../devicetree/bindings/mfd/synology,microp.yaml   | 49 ++++++++++++++++++++++

This is not an "MFD" device.

...

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>
> +
> +    mcu {

Please read previous comments.

Best regards,
Krzysztof