Re: [PATCH] net: mdio: mvusb: drop redundant device reference

[Johan Hovold]

On Fri, Mar 06, 2026 at 07:19:22PM -0800, Jakub Kicinski wrote:
> On Thu,  5 Mar 2026 11:47:22 +0100 Johan Hovold wrote:
> >  	ret = of_mdiobus_register(mdio, dev->of_node);
> >  	if (ret)
> > -		goto put_dev;
> > +		return ret;
> >  
> >  	return 0;
> > -
> > -put_dev:
> > -	usb_put_dev(mvusb->udev);
> > -	return ret;
> 
> better still:
> 
> 	return of_mdiobus_register(mdio, dev->of_node);
> 
> and you can remove int ret; as well

I tend to prefer explicit error paths as combining the two at the end of
a function is a common source of errors where drivers fail to clean up
before returning.

But I'll drop ret in a v2.

Johan