Re: [PATCH] ALSA: hda/realtek: Add headset jack quirk for Thinkpad X390

[Takashi Iwai]

On Sat, 07 Mar 2026 02:29:06 +0100,
Uzair Mughal wrote:
> 
> The Lenovo ThinkPad X390 (ALC257 codec, subsystem ID 0x17aa2288)
> does not report headset button press events. Headphone insertion is
> detected (SW_HEADPHONE_INSERT), but pressing the inline microphone
> button on a headset produces no input events.
> 
> Add a SND_PCI_QUIRK entry that maps this subsystem ID to
> ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK, which enables
> headset jack button detection through alc_fixup_headset_jack()
> and ThinkPad ACPI integration. This is the same fixup used by
> similar ThinkPad models (P1 Gen 3, X1 Extreme Gen 3).
> 
> Signed-off-by: Uzair Mughal <contact@xxxxxxxxxxxxxx>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index XXXXXXX..XXXXXXX 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6998,6 +6998,7 @@
>  	SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> +	SND_PCI_QUIRK(0x17aa, 0x2288, "Thinkpad X390", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK),
>  	SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
>  	SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
> -- 
> 2.43.0

It looks like that the patch is malformed, failing one context line,
and neither git-am nor patch can't apply it cleanly.
Since the code change is trivial, I fixed it locally now.  But at the
next time, please make sure that the patch is really applicable.


thanks,

Takashi