Re: [PATCH V3 4/5] arm64: dts: qcom: x1-crd: Add Embedded controller node

[Krzysztof Kozlowski]

On 09/03/2026 10:03, Sibi Sankar wrote:
> 
> On 3/9/2026 12:55 PM, Krzysztof Kozlowski wrote:
>> On Mon, Mar 09, 2026 at 05:06:45AM +0530, Sibi Sankar wrote:
>>> Add embedded controller node for Hamoa/Purwa CRDs which adds fan control,
>>> temperature sensors, access to EC internal state changes and suspend
>>> entry/exit notifications to the EC.
>>>
>>> Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>>> ---
>>>   arch/arm64/boot/dts/qcom/x1-crd.dtsi | 16 ++++++++++++++++
>>>   1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>>> index ded96fb43489..29a1aeb98353 100644
>>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>>> @@ -1042,6 +1042,16 @@ eusb6_repeater: redriver@4f {
>>>   
>>>   		#phy-cells = <0>;
>>>   	};
>>> +
>>> +	embedded-controller@76 {
>>> +		compatible = "qcom,hamoa-it8987-ec", "qcom,hamoa-ec";
>> I don't see updates to other x1e boards, thus my arguments from v2 stay
>> valid. It's wrong to call it "hamoa-ec" since only one Hamoa board has
>> it. All of other Hamoa boards apparently do not have it.
> 
> 
> Hey Krzysztof,
> Thanks for taking time to review the series :)
> 
> What other Hamoa boards are you referring to? The series
> mentions that the driver and bindings is meant for Qualcomm
> Hamoa/Purwa/Glymur "reference" devices, so it only covers
> CRD and IOT-EVK. It definitely does not cover all Hamoa boards
> boards like you are assuming.

hamoa-ec compatible implies that and that's something I raised in v2
already. You need a specific compatible.


Best regards,
Krzysztof