Re: [PATCH 1/2] media: dt-bindings: ovti,ov8856: Allow props from video-interface-devices

[Sakari Ailus]

Hi Alexander,

Thanks for the patch.

On Sun, Mar 08, 2026 at 04:56:04AM +0000, Alexander Koskovich wrote:
> There is no reason to restrict the allowed rotation degrees to 0 and 180,
> as the sensor can be mounted with any rotation.
> 
> Also, as all the properties described by video-interface-devices.yaml are
> allowed for the image sensor, make them accepted by changing
> additionalProperties: false" to "unevaluatedProperties: false" at the
> schema top-level.

As the relevant properties depend on the device type, I believe we should
continue to document what is relevant for a given device.

Some of the properties such as the ones that get used in the 2nd patch
could well be put into another file so we could avoid documenting each
supported property separately for e.g. raw camera sensors.

Also cc Laurent.

> 
> Signed-off-by: Alexander Koskovich <akoskovich@xxxxx>
> ---
>  Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> index fa71f24823f2..73a9d3288897 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml
> @@ -18,6 +18,9 @@ description: |-
>    through I2C and two-wire SCCB. The sensor output is available via CSI-2
>    serial data output (up to 4-lane).
>  
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
>  properties:
>    compatible:
>      const: ovti,ov8856
> @@ -94,7 +97,7 @@ required:
>    - reset-gpios
>    - port
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> 

-- 
Regards,

Sakari Ailus