Re: [PATCH v2 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor

[Sirat]

On Mon, Mar 9, 2026 at 3:08 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Mar 08, 2026 at 05:37:28PM +0600, Siratul Islam wrote:
> > Add support for the STMicroelectronics VL53L1X Time-of-Flight
> > ranging sensor with I2C interface.
>
> I'm sorry, I missed cover letter, but can you remind if it has the explanation
> that brand new driver is needed because of ...?
>
>

Hi Andy!

Thanks for the review. The existing VL53L0X is very different from the
VL53L1X despite
similar naming. Trying to extend the existing driver would mean
rewriting most of it.

The VL53L1X has a different register map (16-bit addresses vs 8-bit),
requires a 91-byte firmware blob at boot, has a VHV calibration cycle,
and distance
mode/timing budget configuration that doesn't exist on the L0X at all.
Also, newer
abstractions like regmap instead of raw i2c_smbus.

I'll make sure to add the info on the v3 cover letter. The rest of the
review I will address on v3.

Thanks
Sirat