Re: [PATCH v2] vfs: remove externs from fs.h on functions modified by i_ino widening

[Christian Brauner]

On Sat, Mar 07, 2026 at 02:54:31PM -0500, Jeff Layton wrote:
> Christoph says, in response to one of the patches in the i_ino widening
> series, which changes the prototype of several functions in fs.h:
> 
>     "Can you please drop all these pointless externs while you're at it?"
> 
> Remove extern keyword from functions touched by that patch (and a few
> that happened to be nearby). Also add missing argument names to
> declarations that lacked them.
> 
> Suggested-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---

As I said I had already dropped those externs in your original patch but
thanks for sending this. I've taken it.

Fwiw, one or two cycles ago I started with the fs.h header split.
Most of the superblock stuff has been moved from fs.h into:

include/linux/fs/super.h
include/linux/fs/super_types.h

The same thing should ultimately be done for inodes I'm pretty sure.
So I'm happy to take patches for that as well.